-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: beanstalk cleanup #268
Conversation
Codecov Report
@@ Coverage Diff @@
## main #268 +/- ##
=======================================
Coverage 76.12% 76.12%
=======================================
Files 90 90
Lines 6660 6660
=======================================
Hits 5070 5070
Misses 1590 1590
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
zip -r ../artifact.zip . --exclude server/tests/\* server/eb/\* ; ); \ | ||
if ! grep artifact.zip .elasticbeanstalk/config.yml ; then \ | ||
mkdir -p .elasticbeanstalk ; cat config_deploy.yaml >> .elasticbeanstalk/config.yml ; fi | ||
|
||
.PHONY: build-ecs | ||
build-ecs: clean |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can this be moved to the base makefile?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm with one small nit
* Remove unused build steps and comments * Remove gitignore * Remove more stuff * remove more GHA workflows
Should we also remove or rename the |
The EB AWS resource hasn't been destroyed. Is that future work? |
Reviewers
Functional:
@MDunitz
Readability:
Changes